Skip to content

Support line ranges for commit URLs #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
odnoletkov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support line ranges for commit URLs #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion autoload/rhubarb.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,24 @@ function! rhubarb#FugitiveUrl(...) abort
else
let commit = opts.commit
endif
if get(opts, 'type', '') ==# 'tree' || opts.path =~# '/$'
if get(opts, 'type', '') ==# 'commit'
let url = root . '/commit/' . commit
if has_key(opts, 'ancestor')
let url .= '#diff-' . sha256(len(opts.path) > 0 ? opts.path : opts.ancestor.path)
let lines = []
if get(opts, 'line1') > 0
let lines += ['R' . opts.line1]
elseif get(opts.ancestor, 'line1') > 0
let lines += ['L' . opts.ancestor.line1]
endif
if get(opts, 'line2') > 0
let lines += ['R' . opts.line2]
elseif get(opts.ancestor, 'line2') > 0
let lines += ['L' . opts.ancestor.line2]
endif
let url .= join(uniq(lines), '-')
endif
elseif get(opts, 'type', '') ==# 'tree' || opts.path =~# '/$'
let url = substitute(root . '/tree/' . commit . '/' . path, '/$', '', 'g')
elseif get(opts, 'type', '') ==# 'blob' || opts.path =~# '[^/]$'
let escaped_commit = substitute(commit, '#', '%23', 'g')
Expand Down