This repository was archived by the owner on Jul 14, 2023. It is now read-only.
WIP: dont fail if the version is available#4
Open
stavxyz wants to merge 2 commits into
Open
Conversation
stavxyz
force-pushed
the
pyenvinstall
branch
2 times, most recently
from
e31b645 to
4fa7da2
Compare
stavxyz
changed the title
stavxyz
force-pushed
the
pyenvinstall
branch
2 times, most recently
from
94b816d to
341e068
Compare
stavxyz
force-pushed
the
pyenvinstall
branch
13 times, most recently
from
794997d to
bc16152
Compare
Collaborator
Author
|
@blueyed I put this PR together based on this discussion: If you have time, I would appreciate a pair of 👀 |
If the python version is shown by `pyenv versions`, use $PYENV_VERSION to enable the version and retry the operation. Fixes #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the python version is shown by
pyenv versions, and wecan reasonably figure out the correct version to use (esp. if
it matches the name exactly), enable the version with the
PYENV_VERSIONenvironment variable, and try againto find the path to the executable using
pyenv which.With this change, we are resilient to errors like the one
below which is seen when running
pyenv which. Wesimply choose the latest version of python2.6 (for example)
that is available (according to
pyenv versions),set it (using
$PYENV_VERSION), and try again. Again, bydoing this we can usually avoid the following error:
In this case,
tox-pyenvsetsPYENV_VERSIONto2.6.8(the latest version that most closely matches) and retries the operation.
We already know the retry will succeed because we saw
2.6.8in the output from
pyenv versions.This behavior may not be desirable for some, and probably needs a
flag to turn on/off.
Fixes #3
todo
💃