This repository was archived by the owner on Jul 14, 2023. It is now read-only.
Address logger noise#15
Open
stavxyz wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
Python 2.6 and 3.3 can't get isort. Consider downgrading and pinning isort for those versions? The assertions to the Popen calls for python > 3 are failing because of Not sure who/what is calling that. Assert a specific call to Popen for those versions when running in CI? Be less strict about the index of the call we assert. |
jayvdb
approved these changes
Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14