Skip to content

fix(create-granite-app): avoid concurrent tool template writes#302

Open
juntak45 wants to merge 1 commit into
toss:mainfrom
juntak45:fix/create-granite-app-tool-template-race
Open

fix(create-granite-app): avoid concurrent tool template writes#302
juntak45 wants to merge 1 commit into
toss:mainfrom
juntak45:fix/create-granite-app-tool-template-race

Conversation

@juntak45
Copy link
Copy Markdown
Contributor

@juntak45 juntak45 commented May 22, 2026

Summary

  • Apply multiple create-granite-app tool templates through a single package.json merge/write path.
  • Keep the existing single-template helper as a compatibility wrapper.
  • Add a regression test covering biome + eslint-prettier together.

Test Plan

  • cd packages/create-granite-app && yarn exec vitest run src/copyToolTemplate.spec.ts src/transformTemplate.spec.ts src/resolveFallback.spec.ts --root ../..
  • yarn nx run create-granite-app:typecheck
  • yarn eslint packages/create-granite-app/src/copyToolTemplate.ts packages/create-granite-app/src/copyToolTemplate.spec.ts packages/create-granite-app/src/index.ts
  • yarn nx run create-granite-app:build --skip-nx-cache
  • Manual smoke: run built create-granite-app with --tools biome --tools eslint-prettier and verify both tool files/dependencies exist

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

@juntak45 is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 22, 2026

⚠️ No Changeset found

Latest commit: 9323ad9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant