fix: GraniteImage layout on reused cells#299
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b52108f The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
leegeunhyeok
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
Some images were not visible on virtualized list screens
The exact flow was:
GraniteImagealready has a498x498layout area.sourceprop changes andGraniteImage.loadImageIfReady()runs.ImageViewis removed withremoveView().ImageViewis added withaddView().ImageView.ImageViewis added, measure/layout does not run again, so it remains0x0.In other words, during virtual list cell reuse, the outer
GraniteImagemanaged by RN/Fabric had the correct size, but the newly replaced native childImageViewinsideGraniteImagedid not receive layout.The diagnostic logs confirmed that Coil loading succeeded, but the internal
ImageViewstill had a0x0size.Fix
After adding the provider-created internal
ImageView, this change immediately measures and lays it out to the current parentGraniteImagebounds when the parent already has a size.addView(imageView) containerView = imageView layoutContainerViewIfPossible(imageView)This ensures that when only the internal child View is replaced while the outer View is already laid out, the new
ImageViewdoes not stay at0x0and can draw using the parent bounds.