fix: failed to generate migration in SQLite app if JSONField was used with old version

.github/workflows/ci.yml

@@ -100,6 +100,15 @@ jobs:
       - name: Run tests for sqlite
         run:
           just test_sqlite
+      - name: Verify tortoise upgrading for sqlite migrations
+        if: matrix.tortoise-orm == 'tortoise025'
+        run: |
+          TEST_DB=sqlite://db.sqlite3 aerich init-db
+          TEST_DB=sqlite://db.sqlite3 aerich migrate
+          TEST_DB=sqlite://db.sqlite3 aerich upgrade
+          uv pip install --upgrade "tortoise-orm>=1.1"
+          TEST_DB=sqlite://db.sqlite3 aerich migrate
+          TEST_DB=sqlite://db.sqlite3 aerich upgrade
       - name: Show test coverage
         run: just report
 

aerich/migrate.py

@@ -23,6 +23,7 @@
 from aerich.coder import load_index
 from aerich.ddl import BaseDDL
 from aerich.enums import Color
+from aerich.exceptions import NotSupportError
 from aerich.models import MAX_VERSION_LENGTH, Aerich
 from aerich.utils import (
     decompress_dict,
@@ -1022,11 +1023,20 @@ def _handle_field_changes(
             elif option == "description":
                 # change comment
                 cls._add_operator(cls._set_comment(model, new_data_field), upgrade)
+            elif option == "python-type":
+                # When upgrade tortoise-orm from 0.x to 1.x
+                #   JSONField[Union[dict, list]] -> JSONField[dict | list]
+                continue
             else:
                 if modified or (action != "change" and old_new == [("db_default", "__NOT_SET__")]):
                     continue
                 # modify column
-                cls._add_operator(cls._modify_field(model, new_data_field), upgrade)
+                try:
+                    sql = cls._modify_field(model, new_data_field)
+                except NotSupportError:
+                    click.echo(f"{model = }; {field_name = }; {change = }")
+                    raise
+                cls._add_operator(sql, upgrade)
                 modified = True
 
     @classmethod

aerich/version.py

@@ -1 +1 @@
-__version__ = "0.10.1.dev1"
+__version__ = "0.10.1.dev2"