fix #3, #4 and #5#6
Conversation
|
Note to self @torrobinson :
|
| } | ||
| else { | ||
| // Add to the column | ||
| newRow.append(newCell); |
There was a problem hiding this comment.
@avp90 the only issue I can foresee with this is that I had run newRow.append(newCell); BEFORE afterAdd handling because the user's custom afterAdd callback might want to climb up the newCell td and interact with the tr/row itself. I had wanted to only run a column's afterAdd after it was physically added to the row. If it is run any earlier, then it does not exist in the row yet and would be slightly more limited.
Was there a reason you moved it to after the callback handler?
There was a problem hiding this comment.
Yes sure it has a reason, but I don't know anymore why. 😄
Maybe to modify the newCell before add 🤔
There was a problem hiding this comment.
Hmmm if you're not sure of the reason, would you mind please putting the .append back before the afterAdd handler and check to see if your changes still work? I just already know of some personal usage that will break otherwise - unless it was required for your change
2 participants
fix #3, #4 and #5