HTTPHeaders: raise TypeError on non-string keys in set/get/delitem#3650
Open
HrachShah wants to merge 1 commit into
Open
HTTPHeaders: raise TypeError on non-string keys in set/get/delitem#3650HrachShah wants to merge 1 commit into
HrachShah wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3649.
HTTPHeaders.__setitem__,__getitem__, and__delitem__did not validate the key type before calling_normalize_header, which is@lru_cache-wrapped and only acceptsstr. Passing a non-string key (e.g.h[1] = 'x') leakedAttributeError: 'int' object has no attribute 'split'from inside the cache.__contains__already short-circuits the same case withFalse; this patch makes the three other indexers raiseTypeErrorwith a clear message instead, matching the publicMutableMapping[str, str]typing.tests/test/httputil_test.pyadds four regression tests covering__setitem__,__getitem__,__delitem__, and__contains__. The first three fail on master with the originalAttributeErrorand pass on the fix; the contains test pins the existing correct behaviour.python3 -m tornado.test.httputil_test: 60 passed (56 baseline + 4 new). Black-formatted. PR opens on the upstreamtornadoweb/tornadoforkHrachShah/tornadobranchfix/headers-reject-non-string-keys.