httputil: Deprecate some args to HTTPServerRequest constructor#3646
Merged
bdarnell merged 1 commit intoJun 22, 2026
Merged
Conversation
HTTPServerRequest has some redundant and/or obsolete constructor arguments. tornadoweb#3542 cleaned this up a bit, but it included a backwards incompatible change with no deprecation warning. This change adds deprecation warnings in anticipation of deleting the old arguments in Tornado 6.7. In Tornado 6.5, all arguments were officially optional, but things would only partially work without the method and uri arguments. tornadoweb#3542 made either the uri or start_line arguments mandatory. This change makes the method and uri arguments deprecated. It is also deprecated to use method and uri at the same time as start_line (previously method and uri would be silently ignored). In Tornado 6.7, the method, uri, and version arguments will be removed, and start_line will be required. Updates tornadoweb#3500 Updates tornadoweb#3542 Fixes tornadoweb#3637
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTPServerRequest has some redundant and/or obsolete constructor arguments. #3542 cleaned this up a bit, but it included a backwards incompatible change with no deprecation warning. This change adds deprecation warnings in anticipation of deleting the old arguments in Tornado 6.7.
In Tornado 6.5, all arguments were officially optional, but things would only partially work without the method and uri arguments. #3542 made either the uri or start_line arguments mandatory.
This change makes the method and uri arguments deprecated. It is also deprecated to use method and uri at the same time as start_line (previously method and uri would be silently ignored). In Tornado 6.7, the method, uri, and version arguments will be removed, and start_line will be required.
Updates #3500
Updates #3542
Fixes #3637