A comment whose words were rewritten marks the block that replaced them - #525
Merged
Merged
Conversation
On the next version the anchor's words are gone — that is the loop working — and the pin sat beside an unmarked paragraph. The neighbourhood match now says which side the words were on, and the block that replaced them gets a light dashed mark, hidden or not; never the content root. Closes #524. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
PreviewOpen this: https://pr-525-tdoc-preview.jyshi1107.workers.dev/ — the homepage, this PR's code This link is unique to this PR. New commits update the same URL. It is not tdoc.dev. Preview has no Durable Object — concurrent comments use the KV fallback. Data expires in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #524.
findNearContextrecords the side the words were on (tdocSide).blockForMoved()walks from the surviving context to the first real text on the other side and takes its block (p, li, h1–h6, blockquote, pre, td, …); the content root is never painted.tdoc-anchor-moved(light yellow, dashed underline);chrome.csscarries the rule.tdoc-anchor-moved. Pinned inresolved-anchors.test.js. Offline suite green.🤖 Generated with Claude Code