Skip to content

A resolved thread still marks its sentence - #523

Merged
serenakeyitan merged 1 commit into
mainfrom
fix/resolved-anchors-stay-marked
Sep 9, 2026
Merged

A resolved thread still marks its sentence#523
serenakeyitan merged 1 commit into
mainfrom
fix/resolved-anchors-stay-marked

Conversation

@serenakeyitan

Copy link
Copy Markdown
Collaborator

Closes #522.

  • Shell: every thread goes to the frame; those the margin hides are flagged hidden.
  • Probe: a hidden thread is painted in tdoc-anchor-resolved (lighter yellow, dotted underline), gets no pin and no seat, and stays a click target. chrome.css carries the matching rule.
  • Click on the sentence → tdoc:anchorClick → the card opens (the open card is always shown).
  • New offline test resolved-anchors.test.js. Verified on the local server.

🤖 Generated with Claude Code

With the Resolved switch off the shell stopped sending resolved threads
to the frame, and the sentence lost its highlight with its pin. Every
thread reaches the frame now; the hidden ones get a lighter mark, no pin,
no seat, and stay a click target — a click opens the thread.

Closes #522.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Preview

Open this: https://pr-523-tdoc-preview.jyshi1107.workers.dev/ — the homepage, this PR's code
carrying the landing version in this PR's checkout.
Or a document: https://pr-523-tdoc-preview.jyshi1107.workers.dev/d/conway-life/v/2

This link is unique to this PR. New commits update the same URL. It is not tdoc.dev.

Preview has no Durable Object — concurrent comments use the KV fallback. Data expires in 14 days.

@serenakeyitan
serenakeyitan merged commit a6eafd7 into main Sep 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A resolved thread loses its highlight when the Resolved switch is off

1 participant