artifact-shell is green again, and a suite no longer poisons the next one - #513
Merged
Conversation
… one Six failures on main, none of them a broken product. Five were the suite looking in a place the shell stopped using, and one was the fixture no longer meeting its own premise. - Reply box: it asked for a Delete in the card's ⋯ menu, but every control in that menu is gated on the viewer being somebody and this rig browses anonymously, so the trigger correctly never renders. The claim moves to the assertion that fits an anonymous reader — no menu is offered — and Delete stays proved in the authed block that has an identity. - Agent comment: c_fixture_3 is resolved, and resolved threads left the margin when the switch that reveals them was added, defaulting off. The test asks for them first. - Move anchor: also behind the ⋯ menu, also identity-gated. It moves into the authed block and opens the menu instead of hunting for a button that has not been a card descendant since #432. - Dark highlights: the narrow tests before it leave the window at phone width, where the theme control lives in the overflow menu. It comes back to the wide bar first. - Hover outline: the reading template makes an svg fluid, so the fixture's 2400px graph rendered at container width and the overflow the test exists to measure was gone. The fixture pins the width. The sixth was not drift but contamination: the local server writes journey state into the fixture root and nothing cleared it, so a run that stamped `commented` sent the next suite's onboarding wizard to its welcome-back screen — which is how a green ui suite turned red without a line changing. The fixture server clears that scratch on every boot, and it is gitignored. Gated suites, all green: artifact-shell 43, ui 12, responsive 32, browser editing 18, anchor scenarios 10, csp-xss 7. Fixes #512 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
PreviewOpen this: https://pr-513-tdoc-preview.jyshi1107.workers.dev/ — the homepage, this PR's code This link is unique to this PR. New commits update the same URL. It is not tdoc.dev. Preview has no Durable Object — concurrent comments use the KV fallback. Data expires in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #512.
artifact-shellfailed 6 of 43 on main. None of them was a broken product — five were the suite looking where the shell stopped putting things, and one was the fixture no longer meeting its own premise. A seventh problem showed up while fixing them, and it is the interesting one.The five drifts
c_fixture_3is resolved, and resolved threads left the margin when the reveal switch landed (defaults off)The sixth: one suite poisoned the next
While verifying,
ui.test.js— green when #511 merged, unchanged since — went red waiting for the paste step's terminal.The local server writes journey state into the fixture root (
.onboarding.json) and nothing ever cleared it.artifact-shellposts comments, which stampscommented. On the next runstepFromRecordreturnssendback, so the wizard opens on its welcome-back screen and the paste-step markup never appears.So the suites' results depended on what ran before them.
resolveTargetnow clears that scratch on every boot, and both scratch files are gitignored.Verified in the order that used to fail:
artifact-shellthenui— 43/0 then 12/0.All gated suites
npm test: 78 offline suites green.Worth doing next, and out of scope here: these suites still run nowhere. Issue #512 suggests a schedule rather than per-PR, since they need a browser.
🤖 Generated with Claude Code