The document frame is named, not titled - #457
Open
serenakeyitan wants to merge 1 commit into
Open
Conversation
Hovering anywhere in a doc and holding still made Chrome show "Document content" as a tooltip. The text is the shell's iframe title, and the browser uses an iframe's title as the hover label for anything inside it that has none of its own. People noticed it on the landing page's CTA because that is where the cursor stops. aria-label keeps the frame's accessible name and drops the tooltip. Shell bundle rebuilt. Fixes #456. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
PreviewOpen this: https://pr-457-tdoc-preview.jyshi1107.workers.dev/ — the homepage, this PR's code This link is unique to this PR. New commits update the same URL. It is not tdoc.dev. Preview has no Durable Object — concurrent comments use the KV fallback. Data expires in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #456.
Hover the landing page's "Create a free doc" button and hold still: Chrome shows a native tooltip reading Document content. It is not the button's. The shell renders every doc inside
<iframe title="Document content" sandbox="allow-scripts">, and Chrome uses an iframe'stitleas the hover label for anything inside the frame that has notitleof its own. So the label leaks onto every doc, everywhere the cursor rests; the CTA is just where people stop moving.Fix
title→aria-labelon the frame inshell/src/document-shell.jsx. Assistive tech still gets "Document content" as the frame's accessible name; the browser no longer paints it as a tooltip. Nothing else in the tree references the string — no test or selector keys on the iframe's title.Shell bundle rebuilt (
server/runtime/shell.DznZ2B84.js+ manifest); the built output carries"aria-label":"Document content"and notitleon the frame.npm test— 76/76 offline.🤖 Generated with Claude Code