Skip to content

PM-3731 Show roles for design ch in resources tab #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
himaniraghav3 merged 1 commit into from
Feb 19, 2026
Merged

PM-3731 Show roles for design ch in resources tab #1732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 28 additions & 31 deletions src/components/ChallengeEditor/Resources/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,34 +352,33 @@ export default class Resources extends React.Component {
>
<thead className={styles.headTable} role='row'>
<tr>
{!isDesign && (
<th>
<button
<th>
<button
type='button'
onClick={() => {
this.onSortChange({
field: 'Role',
sort: field === 'Role' ? revertSort : 'desc'
})
}}
className={cn(styles['col-2Table'], styles['table-header'])}
>
<span role='columnheader'>Role</span>
<div
className={cn(styles['col-arrow'], {
[styles['col-arrow-sort-asc']]:
field === 'Role' && sort === 'asc',
[styles['col-arrow-is-sorting']]: field === 'Role'
})}
type='button'
Comment thread
himaniraghav3 marked this conversation as resolved.
onClick={() => {
this.onSortChange({
field: 'Role',
sort: field === 'Role' ? revertSort : 'desc'
})
}}
className={cn(styles['col-2Table'], styles['table-header'])}
>
<span role='columnheader'>Role</span>
<div
className={cn(styles['col-arrow'], {
[styles['col-arrow-sort-asc']]:
field === 'Role' && sort === 'asc',
[styles['col-arrow-is-sorting']]: field === 'Role'
})}
type='button'
>
<ReactSVG
path={assets(`${ArrowDown}`)}
/>
</div>
</button>
</th>
)}
<ReactSVG
path={assets(`${ArrowDown}`)}
/>
</div>
</button>
</th>

<th>
<button
onClick={() => {
Expand Down Expand Up @@ -461,11 +460,9 @@ export default class Resources extends React.Component {
{sortedResources.map(r => {
return (
<tr className={styles.rowTable} key={r.id} role='row'>
{!isDesign && (
<td className={styles['col-2Table']}>
<span role='cell'>{r.role}</span>
</td>
)}
<td className={styles['col-2Table']}>
Copy link
Copy Markdown

@github-actions github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ design]
The removal of the conditional rendering for the Role column means that this column will now always be displayed, regardless of whether the challenge is a design challenge or not. Ensure this change is intentional and aligns with the requirements.

<span role='cell'>{r.role}</span>
</td>
<td className={styles['col-3Table']}>
<span role='cell'>
<a
Expand Down
Loading