Skip to content

Fix for how we calculate the submission_end_date to only use the scheduled end date value #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmgasper merged 2 commits into from
Jan 27, 2026
Merged

Fix for how we calculate the submission_end_date to only use the scheduled end date value #45

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b83b3b8
Formatting
jmgasper Jan 19, 2026
5700f11
Fix to use only the scheduled end date for Topgear hourly report, as …
jmgasper Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sql/reports/topgear/hourly.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ registration_end AS (
submission_end AS (
SELECT
cp."challengeId" AS challenge_id,
MAX(COALESCE(cp."actualEndDate", cp."scheduledEndDate")) AS submission_end_date
cp."scheduledEndDate" AS submission_end_date
Copy link

@github-actions github-actions bot Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
Changing the calculation of submission_end_date to use only cp."scheduledEndDate" instead of MAX(COALESCE(cp."actualEndDate", cp."scheduledEndDate")) could lead to incorrect results if actualEndDate is set and differs from scheduledEndDate. Ensure that this change aligns with the intended logic and that actualEndDate is not required for any business logic.

FROM challenges."ChallengePhase" cp
JOIN challenges."Phase" p ON p.id = cp."phaseId"
WHERE p.name IN ('Topcoder Submission', 'Topgear Submission', 'Submission')
Expand All @@ -117,7 +117,7 @@ SELECT
bc.name AS challenge_name,
bc.status AS challenge_status,
ct.name AS challenge_type,
reg.registration_end_date AS registration_end_date,
reg.registration_end_date AS registration_end_date,
se.submission_end_date AS submission_end_date,
pd.latest_actual_end_date AS completed_date,
mt.onsite_efforts AS onsite_efforts,
Expand Down
Loading