Repository navigation
Conversation
What was broken The Let's talk report rendered repetitive campaign metadata and long inquiries in a wide table, forcing horizontal scrolling and excessively tall text columns. Root cause The generic reports table displayed every API column in the same narrow row layout. What was changed Display Let's talk submissions as responsive cards in API order, retaining member ID, contact details and clear UTM labels above the full-width inquiry. Preserve line breaks and wrap long URLs. Hide the seven redundant metadata fields from this view while retaining complete CSV exports and other forms' tables. Update reporting documentation for the companion API and website changes. Any added/updated tests Add page tests for hidden metadata, retained UTM/member values, full-width multiline inquiries, API ordering and unchanged tables for other forms. All 74 reports tests pass. Browser checks at 1440px and 390px confirm readable cards and no horizontal overflow. Validation: yarn lint; yarn test:no-watch --runInBand --testPathPattern=apps/reports/src; NODE_OPTIONS=--max-old-space-size=16384 yarn run build, after nvm use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The Let's talk report rendered repetitive campaign metadata and long inquiries in a wide table, forcing horizontal scrolling and excessively tall text columns.
Root cause
The generic reports table displayed every API column in the same narrow row layout. Companion issues in the website and Forms API caused missing attribution/member identity and oldest-first ordering.
What was changed
Companion PRs: website capture and API ordering. Deploy the API change for newest-first report/CSV ordering and the website change to capture UTM/member values on new submissions.
Any added/updated tests
nvm use:yarn lint,yarn test:no-watch --runInBand --testPathPattern=apps/reports/src, andNODE_OPTIONS=--max-old-space-size=16384 yarn run build. The initial build exceeded Node's default heap; the retry uses a larger heap without changing dependencies or build configuration.