chore: split CI gate from Claude review, fix tool allowlist - #5
Merged
Conversation
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #4
Summary
Fixes the Claude review workflow that was hitting max-turns (30) with 11 permission denials because the allowlist didn't include file-reading tools.
Changes
Architecture: Split into two jobs:
ci— runsnpm ci,lint,typecheck,test,buildas a gate. Fast, cheap, deterministic.review(depends onci) — Claude only does code review. The prompt explicitly tells it CI already passed.Allowlist fix: Added the internal tools Claude Code actually uses to read files:
Read,Grep,Glob,MultiGrepBash(cat:*),Bash(find:*),Bash(ls:*),Bash(head:*),Bash(tail:*),Bash(wc:*)Bash(git diff:*)andBash(git log:*)for diff contextRemoved from Claude's scope: All npm/build commands — those run in the
cijob now.Cost impact: Should cut tokens significantly since Claude won't retry denied tools or run expensive build steps. Max turns reduced to 20 (sufficient for pure review).
CLAUDE.md
Updated to note that CI is a separate gate job.