Skip to content

chore: split CI gate from Claude review, fix tool allowlist - #5

Merged
toolpathguy merged 3 commits into
mainfrom
chore/improve-claude-review-workflow
Jul 22, 2026
Merged

chore: split CI gate from Claude review, fix tool allowlist#5
toolpathguy merged 3 commits into
mainfrom
chore/improve-claude-review-workflow

Conversation

@toolpathguy

Copy link
Copy Markdown
Owner

Relates to #4

Summary

Fixes the Claude review workflow that was hitting max-turns (30) with 11 permission denials because the allowlist didn't include file-reading tools.

Changes

Architecture: Split into two jobs:

  1. ci — runs npm ci, lint, typecheck, test, build as a gate. Fast, cheap, deterministic.
  2. review (depends on ci) — Claude only does code review. The prompt explicitly tells it CI already passed.

Allowlist fix: Added the internal tools Claude Code actually uses to read files:

  • Read, Grep, Glob, MultiGrep
  • Bash(cat:*), Bash(find:*), Bash(ls:*), Bash(head:*), Bash(tail:*), Bash(wc:*)
  • Kept Bash(git diff:*) and Bash(git log:*) for diff context

Removed from Claude's scope: All npm/build commands — those run in the ci job now.

Cost impact: Should cut tokens significantly since Claude won't retry denied tools or run expensive build steps. Max turns reduced to 20 (sufficient for pure review).

CLAUDE.md

Updated to note that CI is a separate gate job.

@toolpathguy
toolpathguy merged commit 74e9c2d into main Jul 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant