Add Take SVG screenshot menu item.#544
Open
heuermh wants to merge 1 commit intotoolbox4minecraft:masterfrom
Open
Add Take SVG screenshot menu item.#544heuermh wants to merge 1 commit intotoolbox4minecraft:masterfrom
heuermh wants to merge 1 commit intotoolbox4minecraft:masterfrom
Conversation
Contributor
Author
Contributor
Author
heuermh
force-pushed
the
svg-screenshot
branch
from
07394b2 to
7712091
Compare
Contributor
Author
|
Rebased, ready for review |
Contributor
Author
|
Any feedback on this pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #327
The SVG documents rendered by Batik via
Graphics2Dare not ideal, but should be an improvement over static PNG screenshots. The widgets and world icons are in separate groups and are selectable. The map image is broken up into tiles as rendered by Amidst.This pull request could be improved -- I've pretty much just copy and pasted the PNG take screenshot code path and made changes for SVG. Some additional thought may be required. Note also the dependency on
batik-allrather than individual modules, with some effort a minimal set ofbatikdependency jars could be determined.