Open
Conversation
tonyarnold
requested changes
Feb 6, 2022
Owner
tonyarnold
left a comment
There was a problem hiding this comment.
Tests that show the problem are my favourite! Thank you for doing this.
It would be good if you could revert the changes to the Xcode project definition before I merge this in.
Author
|
Pushed an update. Also, many thanks for your work maintaining this library! |
tonyarnold
approved these changes
Feb 7, 2022
Author
|
I start to think this might be caused by duplicates in the target 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some patches will cause an out of bounds exception (which would crash if directly applied to any tables). This PR adds two test scenarios that show the behavior.
I am not sure how to fix this, but wanted to share the results of my research.
I also generated a couple of more test cases which will cause the same error: