Reworked the whole companion tab#351
Open
kareking1 wants to merge 7 commits into
Open
Conversation
…error that seems unrelated to my own code, so pushing for now
Contributor
Author
|
Don't merge yet. Code technically works, but openkh can't deserialize when you use my change for some reason I don't know yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A while back I had added the ability to change the knockback types of companions. This allowed them to do damage to enemies they normally deal 1 damage to. However, I didn't like how I left it and felt it wasn't quite in the spirit of a randomizer. Therefore, I made it so the rando can now randomize all kinds of data in atkp! I think this could be for some good casual fun. There are 6 presets to try from and have fun with. Unfortunately, due to some versioning issues with python, I couldn't actually install the requirements. Therefore, I couldn't test my work. I was told to still create a PR for now. If anyone is willing to give me feedback, let me know. Until this versioning issue is fixed, I won't be able to test it seems. I'll look to see if I missed anyway to fix it in the meantime.