feat: ship default bundles and improve runtime safety#152
feat: ship default bundles and improve runtime safety#152
Conversation
Signed-off-by: Ivan Iufriakov <tomatyss@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f702d76264
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if command -v su >/dev/null 2>&1; then | ||
| su -s /bin/sh "$user" -c "$*" | ||
| return |
There was a problem hiding this comment.
In scripts/acceptance_debian_container.sh, the su fallback uses su ... -c "$*", which flattens arguments and loses the original quoting. When runuser is unavailable (e.g., minimal containers), a call like run_as_user runloop sh -c "umask 0002; ..." becomes sh -c umask 0002; ..., so the umask runs in a child shell and does not apply to the actual runloopd/rlp command; more complex arguments with spaces or metacharacters can also be misparsed. This can make the acceptance script behave differently (e.g., default umask, unexpected command parsing) on hosts that lack runuser.
Useful? React with 👍 / 👎.
Wrap ops doc line to satisfy markdown lint. Signed-off-by: Ivan Iufriakov <tomatyss@gmail.com>
Ignore CONTINUITY.md in git. Signed-off-by: Ivan Iufriakov <tomatyss@gmail.com>
Remove CONTINUITY.md from git index so .gitignore applies. Signed-off-by: Ivan Iufriakov <tomatyss@gmail.com>
1 participant
Summary
Testing
Checklist