Add low-noise team observability and harden the runtime - #13
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7089433b6f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Burn attempt budget before any dispatchable metadata is published. A | ||
| // crash may conservatively consume an attempt, but can never create an | ||
| // uncounted prepared run that launch would accept. | ||
| for (const m of rows) m.budget = budget({ stateDir: home(), task: m.budget_task, record: true, limits: caps }); |
There was a problem hiding this comment.
When a writer worktree is already leased, this loop increments the task's run counter before reserveWriter discovers the conflict. The failed prepare creates no run metadata, but with --max-runs 1 a user who removes the conflicting lease and retries is rejected because the sole attempt was silently consumed. Check/reserve the writer lease before recording the budget, while retaining rollback or crash-safe ordering.
Useful? React with 👍 / 👎.
1 participant
Summary
watch --fullwhile suppressing unchanged roster spamValidation
node --test tests/*.test.mjs(105 passed)bash tests/caps.sh(67 passed)bash tests/route.sh(105 passed)bash tests/delivery.sh(25 passed)bash tests/gate.sh(30 passed)bash tests/inspect.sh(13 passed)