Repository navigation
fix(i2c): enable ESP32-S3 slave input filters - #137
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESP32-S3 I2C targets currently initialize with a zero input-filter threshold. Short line glitches can advance the target state machine and terminate reads early. Set the SDA and SCL input filters to seven cycles, matching the usual master configuration; other targets are unchanged.
Add a single-board slave-v2 regression that checks both filters on both S3 controllers over three open/close cycles, including reopening after a different filter setting. Register the slave-v2 single-board test configuration for ESP32-S3.
Validation:
slave_v2enabled.Expected 7 Was 0); patched driver passed (1 Tests 0 Failures 0 Ignored).The register regression checks initialization and reuse; it does not inject electrical glitches or establish a precise pulse-rejection limit. The CI configuration is added and builds locally; remote hardware CI has not run yet.