Add version info, setup checks, Makefile options#668
Open
inus wants to merge 1 commit intotoitlang:mainfrom
Open
Add version info, setup checks, Makefile options#668inus wants to merge 1 commit intotoitlang:mainfrom
inus wants to merge 1 commit intotoitlang:mainfrom
Conversation
floitsch
reviewed
Jan 11, 2026
| @success_count=0; \ | ||
| skip_count=0; \ | ||
| failed=0; \ | ||
| for chip in esp32 esp32c3 esp32s2 esp32s3; do \ |
Member
There was a problem hiding this comment.
Suggested change
| for chip in esp32 esp32c3 esp32s2 esp32s3; do \ | |
| for chip in esp32 esp32c3 esp32c6 esp32s2 esp32s3; do \ |
Comment on lines
+20
to
+21
| // New helper functions | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| // New helper functions |
| versionFile := filepath.Join(sdkPath, "SDK_VERSION") | ||
| data, err := os.ReadFile(versionFile) | ||
| if err != nil { | ||
| return false, nil // missing or error → not current |
Member
There was a problem hiding this comment.
Suggested change
| return false, nil // missing or error → not current | |
| return false, nil // Missing or error -> not current. |
Member
|
Thanks for the PR. The "problem" is that the PR conflicts with #666 (and maybe #667). Could you split the PR in two (or three):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more verbose version information
Change jag setup to check for and avoid re-downloads
Add install, uninstall and sync-cache options to make
Fix 'make test' to skip missing chip firmware
--
E.g.: