feat(optimizer)!: type annotation for databricks NANVL, SIGN, SHIFTLEFT, SIGNUM, SHUFFLE#7896
Merged
Merged
Conversation
Contributor
SQLGlot Integration Test Results✅ All tests passedComparing: Overallmain: 192414 total, 153544 passed (pass rate: 79.8%) sqlglot:type-inference-batch-7: 180220 total, 142397 passed (pass rate: 79.0%) Transitions: Dialect pair changes: 0 previous results not found, 3 current results not found ✅ All tests passed |
fivetran-amrutabhimsenayachit
force-pushed
the
type-inference-batch-7
branch
4 times, most recently
from
July 17, 2026 19:02
c52a53d to
3a94107
Compare
geooo109
reviewed
Jul 20, 2026
Collaborator
|
@fivetran-amrutabhimsenayachit let's please not couple >1 function annotations in one PR. It makes reviewing and decoupling patching more difficult than it needs to be. |
fivetran-amrutabhimsenayachit
force-pushed
the
type-inference-batch-7
branch
2 times, most recently
from
July 20, 2026 17:22
f406cea to
b1c66cc
Compare
geooo109
approved these changes
Jul 21, 2026
geooo109
reviewed
Jul 21, 2026
fivetran-amrutabhimsenayachit
force-pushed
the
type-inference-batch-7
branch
4 times, most recently
from
July 21, 2026 15:05
fdc0e17 to
ad0cce6
Compare
fivetran-amrutabhimsenayachit
force-pushed
the
type-inference-batch-7
branch
from
July 21, 2026 15:11
ad0cce6 to
7c713ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
class Nanvl(Func)toexpressions/math.pyandclass Shuffle(Func)toexpressions/array.pyexp.Nanvlandexp.Signto the DOUBLE group insqlglot/typing/spark.py(overrides base INT annotation)exp.Shuffleinsqlglot/typing/databricks.pyannotate_functions.sql(2× SHIFTLEFT, 3× SIGNUM, 1× SHUFFLE)test_shuffle_type_annotationinsqlglot-integration-testsCloses RD-1229681, RD-1229682, RD-1229683, RD-1229690, RD-1229691