docs(copilot): judge a pull request before it is clean

[toasterbook88]

Summary

• The Copilot pull-request skill no longer stages everything, amends, force-pushes, adds a Co-authored-by trailer, or enables auto-merge.
• A review thread is resolved after the patch and a test are on the branch, or after the operator declines the finding.
• Squash merge waits until the operator names that pull request. --admin is omitted when the pull request is already CLEAN.
• A plain go build may print vcs.revision, including a dirty tree. built: stays the ldflag timestamp.

Dependabot auto-merge and the generated pr-truth-audit lock are unchanged. CI builds with -buildvcs=false, so this workflow change does not add a version-string test.

Test plan

• GOTOOLCHAIN=go1.26.6 make ci-preflight passed on this branch before the prompt was inlined
• ./hack/verify-public-boundary.sh passed on the committed prompt

[toasterbook88]

AXIS Grok gate

Verdict: PASS-WITH-RISK. No APPROVE.

PR #490 docs(copilot): judge a pull request before it is clean
Head: 9a1a5ad53e8a8d618dc9a778cafb8844980e5893
Base: main @ cb202b8e81c3141ed42124f15e5d1f40c91e5255
Files: .github/copilot/skills/pr-review-responder.yml (+44 / -66). One commit. Docs/prompt only.

Invariant check:

• Advisory vs fact plane: the skill now says GitHub CLEAN is branch protection, not fit-to-land. No snapshot, placement, or status path is touched.
• HITL: removes git add -A, amend of a remote commit, force-push, mandatory Co-authored-by, and feature/fix auto-merge. Squash merge is gated on the operator naming that pull request. Does not touch confirm/dispatch locks.
• Cache badge / --live: not in this diff.
• Prohibited surfaces: no secret_read, ssh_bypass, fleet_exec, spawn_subagent, self-authorize, or daemon restart. Prompt says leave internal/buildinfo/version.go unchanged and do not restart daemons in the merge step. Dependabot auto-merge and pr-truth-audit.lock.yml are explicitly left alone.
• Agent self-model: skill text only. No fleet inventory.

Residuals:

• "Omit --admin when the state is already CLEAN" does not forbid --admin when the PR is not CLEAN. A Copilot session can read that as permission to admin-merge a blocked PR once the operator names it.
• The name-the-PR gate is prompt text, not a code gate.
• Test plan says make ci-preflight passed before the prompt was inlined. ./hack/verify-public-boundary.sh is the check claimed on the committed prompt.
• Version note matches the existing ldflag / -buildvcs=false split (built: is the ldflag timestamp; plain go build may print vcs.revision, including dirty). No version test added, as the PR states.

CI at review (head 9a1a5ad): Test & Build, govulncheck, Analyze (actions), and copilot-pull-request-reviewer in progress. auto-merge skipped. Combined status success is Devin Review "trial expired / skipped", not a code check. mergeable_state is blocked.

Operator action: wait for required checks. Do not treat this COMMENT as approval. If this skill is used, do not pass --admin unless a separate operator command says so.

[Copilot]

Copilot review overview

🟡 Changes recommended

The workflow permits some auto-merges and documents build/toolchain behavior inaccurately.

Review effort: Balanced
Findings: 1 · 2

Open (3)

• Make the auto-merge prohibition unconditional · New
• Include the go prefix in the GOTOOLCHAIN value · New
• Implement or remove unsupported build metadata behavior · New

What changed in this PR

Updates the Copilot PR-handling skill to require explicit operator approval and safer branch handling.

Changes:

• Removes force-pushing, commit amendment, automatic staging, and automatic merging.
• Tightens review-thread resolution and merge requirements.
• Documents build metadata expectations.

File	Description
.github/​copilot/​skills/​pr-review-responder.yml	Revises the Copilot PR workflow and safety constraints.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[toasterbook88]

Ship with two fixes. Ban auto-merge on every pull request, not only feature and fix. Drop the version paragraph that describes a dirty-tree line the binary does not print. The --admin line should stay forbidden unless a separate operator command says so. Not a user-facing mode. Not merging from this comment.