Skip to content

Hi goodtimes: expand nearest-pointing window from 7 to 9#1

Closed
Copilot wants to merge 2 commits into
devfrom
copilot/update-goodtimes-algorithm
Closed

Hi goodtimes: expand nearest-pointing window from 7 to 9#1
Copilot wants to merge 2 commits into
devfrom
copilot/update-goodtimes-algorithm

Conversation

Copy link
Copy Markdown

Copilot AI commented May 20, 2026

This updates Hi goodtimes repoint selection to use the current repoint plus nearest 8 pointings (9 total), as requested. The change is centralized at the existing global configuration point so both dependency expansion and trigger fan-out follow the new window size.

  • Scope

    • Increase HI_GOODTIMES_NUM_NEAREST_REPOINTS from 7 to 9 in:
      • sds_data_manager/lambda_code/SDSCode/pipeline_lambdas/dependency.py
  • Behavior impact

    • get_hi_goodtimes_target_repoints() now returns the larger [T-N+1, T+N-1] range with N=9.
    • Hi L1B DE special handling in batch_starter.py already delegates to that helper, so submission fan-out automatically uses the new value.
    • Hi goodtimes L1B DE dependency extension logic in dependency.py already reads the same constant, so nearest-file selection and gating behavior are updated consistently.
  • Regression guard

    • Added a focused assertion of the new default value in:
      • tests/lambda_endpoints/test_dependency_api.py
# dependency.py
HI_GOODTIMES_NUM_NEAREST_REPOINTS = 9

Agent-Logs-Url: https://github.com/tmplummer/sds-data-manager/sessions/fda2fba9-8a72-4bd9-bf19-ed26d5ae68f5

Co-authored-by: tmplummer <16110870+tmplummer@users.noreply.github.com>
Copilot AI changed the title [WIP] Update goodtimes algorithm to use nearest 9 pointings Hi goodtimes: expand nearest-pointing window from 7 to 9 May 20, 2026
Copilot AI requested a review from tmplummer May 20, 2026 15:42
@tmplummer tmplummer marked this pull request as ready for review May 20, 2026 17:21
@tmplummer tmplummer closed this May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hi goodtimes - use nearest 9 pointings

2 participants