fix: restrict bool env vars to 1/0/true/false#63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
_parse_boolpreviously treated any non-empty env string asTrue, meaningYAS_FULL_WIDTH=0andYAS_FULL_WIDTH=falseboth resolved toTrue. This made it impossible to explicitly disable boolean flags via environment variables when ayas.tomldefault had them enabled.Changes
_parse_boolinclaude/yas/config.pynow requires env/CLI boolean strings to be one of1,0,true,false(case-insensitive viajson.loads). Any other value is rejected and falls through to the config default.BOOL_ALLOWLISTconstant documenting the accepted set.import jsonin to leveragejson.loadsfor"true"/"false"→boolparsing.test_env_full_width_any_nonempty_is_trueand split into truthy values, falsy values, invalid-falls-through-to-default, env-overrides-toml-true, and max-width-respected-when-full-width-disabled cases.0.2.11.Checklist
Screenshots / recording
Benchmark
System info