Apply corrections from the said-preview review (tlon-apps#6156) - #3
Open
arthyn wants to merge 6 commits into
Open
Apply corrections from the said-preview review (tlon-apps#6156)#3arthyn wants to merge 6 commits into
arthyn wants to merge 6 commits into
Conversation
From mikolajpp's and Fang-'s review: - comment discipline: lowercase comments, flag-comment form for code segments, no tutorial-style/self-explanatory comments (hoon or shell) - documentation style: terse `$name: purpose` first line, .field/$type references, no padding - error handling: one meaning per semantic error response; generic error channel for genuine failures; don't crash the host for semantically clear errors - test conventions: spell bind:m (no =* aliasing), +do-as for temporary src, bare-argument gate calls - pitfall: +rear/+snip mull-fail on ?~-narrowed lests - marks: version suffixes track wire revisions — new marks start unversioned, suffix pairs with path version - gall: %leave expels the wex entry in the same event; no lingering subscription to work around Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fang-
reviewed
Jul 29, 2026
Co-authored-by: fang <github@fang.io>
Co-authored-by: fang <github@fang.io>
Fang's review of the said-preview corrections flagged several rules as over-generalized from one PR's context: - Drop the /v0/said endpoint mention from the comment-style example; endpoints don't belong in type docs. - Delete the %watch-ack bad/good pair under One Meaning per Error Response — the two snippets were near-identical, so the prose carries it alone. - Scope the "don't crash for a semantically clear error" corollary to interfaces that already answer in responses. Rejecting a subscription on permissions by crashing stays correct. - Move the bare-argument/auto-cons rule out of Test Conventions into Common Idioms next to Same-Subject Cell Collapse, and note that the splice only reaches the trailing element. - Soften the mark-suffix/path-version pairing and replace the false example: channels serves %channels on both /x/v0 and /x/v1, and /x/v3/heads gives %channel-heads-2. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captures the style and semantics corrections from @mikolajpp's and @Fang-'s review of tloncorp/tlon-apps#6156 so future generated code imitates the right things:
patterns.md
::), and a prohibition on tutorial-style / self-explanatory comments — with the exact before/after from the review.bind:mat each monadic step (no=*aliasing),+do-asfor temporarysrc.bowl, bare-argument gate calls over literal cells.%deniedetc.) mean exactly one condition; genuine failures get a generic error channel; don't crash the host for semantically clear errors.+rear/+snipmull failure when called on?~-narrowed lests, with the head/tail-walk alternative.architecture.md
$name: purposefirst line,.field/$typereferences, no padding.wexentry in the same event it processes%leave(and nonces wires internally) — no lingering-subscription workarounds.🤖 Generated with Claude Code