changelog: date 2.0.0 for the day it ships, and record the two fixes that landed after it - #19
Merged
Merged
Conversation
…fter it
The 2.0.0 entry was written on the fourth and dated the fourth, and then
nothing tagged it. Two fixes have merged into `main` since, both of them
user-visible and neither of them in the changelog, because the entry was
already closed: `daemon status` answering `{}` for a stopped daemon, and
`chat.list` repeating its first page because the dialog cursor carried
`access_hash=0`.
Since 2.0.0 was never published, the honest form is one entry rather than a
2.0.0 nobody could install and a 2.0.1 the next day. Both fixes are in
`### Fixed` and the heading carries the date the tag is actually cut.
This is the last commit before `git tag -a v2.0.0`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge this last. It is the commit immediately before
git tag -a v2.0.0,and it depends on #17 and #18 being in.
The 2.0.0 entry was written on 4 September and dated 4 September, and then
nothing tagged it. Two user-visible fixes have merged into
mainsince andneither is in the changelog, because the entry was already closed:
daemon statusencoding to{}for a stopped daemon (daemon status: say running=false when offline; upgrading notes for editable installs #16), so the onecommand that exists to say the daemon is down could not say it.
chat.listrepeating its first page because both dialog-cursor buildersused
access_hash=0(chat.list: carry the access hash into the dialog cursor #17). 34 rows before, 600+ across six pages after, ona live 936-dialog account.
Since 2.0.0 was never published there is no released artefact to contradict,
so one entry is more honest than a 2.0.0 nobody could install plus a 2.0.1 the
next day. Both fixes go under
### Fixedand the heading takes the date thetag is actually cut.
After this merges
release.ymlfrom #18 does the rest: version agreement across the tag,tlgr.__version__and this heading; the acceptance suite against the taggedtree; sdist and wheel; a clean-environment install of the wheel; then the
GitHub release with this section as its notes and both artefacts attached.