Open
Conversation
- After each line of caller ID data, check whether both a name and number field have been received and only then advance to STATE_CALLERID. This allows proper functionality regardless of the order in which the caller ID data is sent by the modem. (closes tkdrob#3) - Accept DDN_NMBR as an alias for NMBR in caller ID data. (closes tkdrob#2)
Author
|
Hi @tkdrob, is there anything I can do to help move this PR forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
number field have been received and only then advance to
STATE_CALLERID. This allows proper functionality regardless of the
order in which the caller ID data is sent by the modem. (closes if NMBR arrives after NAME, the callerid notification will miss the phone number #3)