Multi folder#16
Merged
Merged
Conversation
…ting integration tests pass based on ImageFolder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for multiple image folders
Move dev settings to
appsettings.Development.jsonfor backend APIImageFoldertakes precedence overImageFoldersconfig for now due to issues with integration tests. IfImageFoldersis defined inappsettings.Development.json, the tests would need env vars for all possible array entries to override or some other solution to set or unset config specific to tests. Using a specific Testing environment causes odd issues where the apphost tries to do a health check on the next port in sequence to the services and fails. Need to resolve to implement tests for multi-folder.