Repository navigation
Add ASCII wireframes of UI changes, independent of the Playwright preview - #190
Merged
Merged
Conversation
…view For each screen or modal a pull request adds, removes or changes, draw a compact before/after ASCII wireframe from the diff alone and post it as its own durable comment. One cheap model call, no browser, no target-repo CI, no dependency on whether a repository has opted into actions/ui-preview — src/wireframe stays independent of src/preview end to end, including duplicating is_ui_path rather than importing it. On by default; enabled and max_screens are repository-overridable, only downward, the same posture as preview.enabled/max_flows.
Tiny Sweeper review
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/wireframemodule: one model call over a pull request's UI-touching diff files, asking for a compact before/after ASCII wireframe of each screen or modal the diff adds, removes, or changes.src/previewend to end — no browser, no target-repo CI, no dependency on whether a repository has opted intoactions/ui-preview.is_ui_pathis duplicated rather than imported frompreview::planso the two heuristics can't drift into each other by accident.src/app/apply.rs::publish_wireframe, markerwireframe::render::MARKER), edited in place on every push — not folded into the review hub, since a screen-by-screen gallery can be the bulkiest thing the bot posts.Proposal::wireframeinsrc/app/review.rs, the same shapeProposal::overviewalready uses.[wireframe]config: on by default;enabled/max_screensare repository-overridable (only downward, same posture aspreview.enabled/max_flows);max_width/max_heightstay operator-only, same reasoning as[grouping]'s ceilings.Test plan
cargo fmt --all -- --checkcargo clippy --locked --all-targets -- -D warningscargo test --locked(2036 passed)cargo check --locked --all-features --all-targetsmax_screensare dropped and counted) and for the rendered comment body