Fix legacy orchestration route contract - #37
Conversation
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Ready for maintainer review Review snapshot
Completeness: Complete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. How this fits togetherflowchart LR
n0["..._api_key_request_uses_openapi_field_names"]:::impacted
n1["path_segments_are_encoded_on_typed_routes"]:::impacted
n2["create"]:::impacted
n3["try_from"]:::impacted
n4["get_feedback"]:::impacted
n5["...ejects_the_machine_only_connections_scope"]:::impacted
n0 -->|calls| n2
n0 -->|tests| n2
n1 -->|calls| n4
n1 -->|tests| n4
n5 -->|calls| n3
n5 -->|tests| n3
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
Comment |
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0031 · 118,117 in / 7,132 out · 6,368 cached (5%) · ladder/vectors, gpt-5.6-luna, deepseek-v4-flash · 146 embedded
critique: $0.0014 · 50,943 in / 1,447 out · 2,026 cached (4%) · gpt-5.6-luna
security: $0.0012 · 47,942 in / 892 out · 1,782 cached (4%) · gpt-5.6-luna
tests: $0.0003 · 12,759 in / 1,422 out · 1,536 cached (12%) · deepseek-v4-flash
description: $0.0001 · 4,127 in / 871 out · 1,024 cached (25%) · deepseek-v4-flash
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63ee37316f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ] | ||
| }, | ||
| { | ||
| "name": "orchestration", |
There was a problem hiding this comment.
Document the added orchestration namespace
When this compatibility route is published, docs/api-surface.md still omits the orchestration namespace and gives no indication that this deprecated endpoint is available only through the raw transport. Consumers following the public API guide therefore cannot discover the newly exposed contract; update the namespace table and explanatory text alongside the generated registry.
AGENTS.md reference: AGENTS.md:L162-L168
Useful? React with 👍 / 👎.
Summary
Add the authenticated legacy
GET /orchestration/v1/sessionscompatibility path to the generated public route registry and API manifest. Update the contract count test.The companion backend change will serve an empty list for installed OpenHuman clients that still poll this retired path. No typed SDK method is added for the deprecated endpoint.
API or behavior changes
The raw SDK transport permits
GET /orchestration/v1/sessionsonce the backend compatibility route is deployed.Validation
cargo fmt --all -- --check— passedcargo test --quiet— passednode scripts/sync-openapi.mjs --input /tmp/sentry-36239-spec.jsonRelated issue
Summary by CodeRabbit