Skip to content

Fix legacy orchestration route contract - #37

Merged
senamakel merged 2 commits into
mainfrom
fix-sentry-36239-legacy-sessions
Sep 25, 2026
Merged

senamakel merged 2 commits into
mainfrom
fix-sentry-36239-legacy-sessions

Conversation

@senamakel

@senamakel senamakel commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Summary

Add the authenticated legacy GET /orchestration/v1/sessions compatibility path to the generated public route registry and API manifest. Update the contract count test.

The companion backend change will serve an empty list for installed OpenHuman clients that still poll this retired path. No typed SDK method is added for the deprecated endpoint.

API or behavior changes

The raw SDK transport permits GET /orchestration/v1/sessions once the backend compatibility route is deployed.

Validation

  • cargo fmt --all -- --check — passed
  • cargo test --quiet — passed
  • Manifest regenerated from the companion backend checkout's raw Swagger spec with node scripts/sync-openapi.mjs --input /tmp/sentry-36239-spec.json

Related issue

Summary by CodeRabbit

  • New Features
    • Added an authenticated orchestration endpoint for listing sessions, returning an empty list for compatibility with older clients.

@tinysweeper

tinysweeper Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Ready for maintainer review
Priority: none
Reviewed head: 63ee37316f69
Updated: 1790357524 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 1 Active findings 0
Tests 1 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 1 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

How this fits together

flowchart LR
  n0["..._api_key_request_uses_openapi_field_names"]:::impacted
  n1["path_segments_are_encoded_on_typed_routes"]:::impacted
  n2["create"]:::impacted
  n3["try_from"]:::impacted
  n4["get_feedback"]:::impacted
  n5["...ejects_the_machine_only_connections_scope"]:::impacted
  n0 -->|calls| n2
  n0 -->|tests| n2
  n1 -->|calls| n4
  n1 -->|tests| n4
  n5 -->|calls| n3
  n5 -->|tests| n3
  classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
  classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
  classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
  classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Loading
Agent review details

critique

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Reviewed 3 files; 0 findings. _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

security

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Reviewed 3 files; 0 findings. _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

tests

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Adds the retired `/orchestration/v1/sessions` route back to the public route list for backward compatibility, updates the manifest and test counts, and documents the change in comments. No behavioural defects introduced. _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Adds the legacy `GET /orchestration/v1/sessions` route to the public registry and updates the manifest and test assertions to match. The change is small, consistent with the repo rules, and introduces no defects. _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

e2e

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No end-to-end harness in this repository: no e2e test files and no e2e workflow.
Evidence and run details
  • Models: ladder/vectors, gpt-5.6-luna, deepseek-v4-flash
  • Spend: $0.003075
  • Tokens: 118117 input · 7132 output · 6368 cached · 146 embedding
Head State Pass summary
63ee37316f69 ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 1790357524)

tinysweeper 0.1.0

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T17:33:30.230528Z 63ee373 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 0ff47d5a-5fff-4361-9a42-5e605914d6ea

📥 Commits

Reviewing files that changed from the base of the PR and between a8ea407 and 63ee373.

📒 Files selected for processing (3)
  • api/tinyhumans.backend.json
  • src/generated_public_routes.rs
  • tests/openapi_sync.rs
 ___________________________________
< Mission: Impossible - Rogue Code. >
 -----------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

             $0.0031 · 118,117 in / 7,132 out · 6,368 cached (5%)  · ladder/vectors, gpt-5.6-luna, deepseek-v4-flash · 146 embedded
critique:    $0.0014 · 50,943 in  / 1,447 out · 2,026 cached (4%)  · gpt-5.6-luna
security:    $0.0012 · 47,942 in  / 892 out   · 1,782 cached (4%)  · gpt-5.6-luna
tests:       $0.0003 · 12,759 in  / 1,422 out · 1,536 cached (12%) · deepseek-v4-flash
description: $0.0001 · 4,127 in   / 871 out   · 1,024 cached (25%) · deepseek-v4-flash

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Sep 25, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 63ee37316f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

]
},
{
"name": "orchestration",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Document the added orchestration namespace

When this compatibility route is published, docs/api-surface.md still omits the orchestration namespace and gives no indication that this deprecated endpoint is available only through the raw transport. Consumers following the public API guide therefore cannot discover the newly exposed contract; update the namespace table and explanatory text alongside the generated registry.

AGENTS.md reference: AGENTS.md:L162-L168

Useful? React with 👍 / 👎.

@senamakel
senamakel merged commit 3427d96 into main Sep 25, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant