Conversation
Sync the public route registry and manifest against backend main:
- add GET /opencompany/companies, the company-template catalog the
dashboard and landing read to let users pick a company on create
- restore POST /opencompany/instances/{slug}/update, which a prior bare
resync against the deployed spec had dropped from PUBLIC_ROUTES
- operationCount 206 -> 208; update the pinned counts in openapi_sync
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 2 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Changes requested Review snapshot
Completeness: Complete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. Findings
Before merge
How this fits togetherflowchart LR
n0["..._api_key_request_uses_openapi_field_names"]:::impacted
n1["path_segments_are_encoded_on_typed_routes"]:::impacted
n2["create"]:::impacted
n3["try_from"]:::impacted
n4["get_feedback"]:::impacted
n5["...ejects_the_machine_only_connections_scope"]:::impacted
n0 -->|calls| n2
n0 -->|tests| n2
n1 -->|calls| n4
n1 -->|tests| n4
n5 -->|calls| n3
n5 -->|tests| n3
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Comment |
There was a problem hiding this comment.
Requesting changes: 1 lane(s) blocking, worst finding is high.
Fix or reply to the findings below and push. The next review clears this automatically once they are gone — you should not need to dismiss anything by hand.
$0.0090 · 110,489 in / 10,359 out · 9,761 cached (9%) · ladder/vectors, gpt-5.6-luna, deepseek/deepseek-v4-flash · 153 embedded
critique: $0.0032 · 42,121 in / 2,673 out · 2,026 cached (5%) · gpt-5.6-luna, deepseek/deepseek-v4-flash
security: $0.0031 · 48,549 in / 1,003 out · 3,639 cached (7%) · gpt-5.6-luna
tests: $0.0015 · 12,776 in / 1,807 out · 0 cached (0%) · deepseek/deepseek-v4-flash
description: $0.0007 · 4,217 in / 2,510 out · 1,280 cached (30%) · deepseek/deepseek-v4-flash
| // "update to latest" — both are served by the backend `main` this syncs | ||
| // against (sdk main had been generated from the deployed spec that predated | ||
| // them). | ||
| assert_eq!(manifest["source"]["operationCount"], 208); |
There was a problem hiding this comment.
Update the manifest before raising the operation count
The diff adds two routes to PUBLIC_ROUTES and changes the expected manifest operation count to 208, but it does not update the checked-in api/tinyhumans.backend.json. The manifest therefore still has the previous operation count and route set, causing this assertion and the subsequent rust_routes/manifest_routes equality check to fail. Add both routes to the manifest (and its derived metadata) or do not change the generated registry and expectations.
[RULE] contract-parity ·
There was a problem hiding this comment.
This is a false positive. api/tinyhumans.backend.json is updated in this same commit (b17b6c7): "operationCount": 208 and "totalOperationCount": 262, with both GET /opencompany/companies and POST /opencompany/instances/{slug}/update present in the namespace routes. The generated_rust_routes_match_the_public_manifest test — which asserts both operationCount == 208 and rust_routes == manifest_routes — passes in the green Rust SDK CI run for this commit, so the described assertion failure does not occur. No change needed.
Syncs the public Rust SDK contract against backend
mainfor the new company-template picker (backend PR tinyhumansai/backend#1365).Generated via
scripts/sync-openapi.mjs --input <branch spec>:GET /opencompany/companies— the company-template catalog the dashboard and landing read so users can pick a company on create.POST /opencompany/instances/{slug}/updatetoPUBLIC_ROUTES. It shipped in feat: add opencompany instance update route to the contract #30 but a later bare resync against the deployed spec (which predated the route) reverted it back out; it is served bymain.operationCount206 -> 208; pinned counts intests/openapi_sync.rsupdated to match.Verification:
cargo fmt --all -- --check,cargo clippy --all-targets -- -D warnings, andcargo testall clean.Companion to tinyhumansai/backend#1365; the backend
sdkgitlink should be bumped to this commit once merged.