-
Notifications
You must be signed in to change notification settings - Fork 4k
feat(harness): remove the todos kanban board, surface todos and goals in chat #6445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
73 commits
Select commit
Hold shift + click to select a range
5af287b
chore(deps): add vendor dependencies for tinyagents and tinymcp
senamakel eb84dfa
chore(deps): update tinyagents submodule
senamakel 5b1c829
chore(goals): remove legacy file-backed goal migration code
senamakel eaaf76d
chore(todos): align type names and remove timestamp normalization
senamakel 0d1cd42
refactor(todo): replace task-board types with simpler todo types
senamakel 73f12e3
chore(agent): remove unused task_board_id and task_card_id fields fro…
senamakel 5deb7d5
chore(deps): update tinyagents submodule
senamakel 8c56c8f
refactor(todo): rename TodoItem to TodoArg for clarity
senamakel 49bd98f
chore(config): remove require_task_plan_approval field
senamakel 00d502b
test(config): remove require_task_plan_approval from autonomy setting…
senamakel 7c00ec0
test(json_rpc_e2e): remove task_board_id and task_card_id from test a…
senamakel e325006
refactor(settings): remove task plan approval toggle
senamakel 5532d9b
test(settings): remove obsolete require_task_plan_approval tests
senamakel 2878aa5
fix(test): correct comment line wrapping in AgentAccessPanel test
senamakel 45a2f6e
chore(i18n): remove deprecated task board and task plan approval keys
senamakel bdeec7c
chore(i18n): remove unused work task translation keys
senamakel 6c8bfbf
chore: remove outdated references to task-board concept across codebase
senamakel f064a70
chore: files changed app/src/features/conversations/Conversations.pro…
senamakel 47980b5
docs(agent): remove stale reference to `task_board.rs` in README
senamakel 4ec2550
docs(readme): update Goals & Todos description to mention agent's ses…
senamakel 39d6738
feat(goals): return structured goal payload from goal tools
senamakel 3dce23d
test(goals): strengthen tool result assertions with structured payloa…
senamakel 16ab522
fix(agent): correct comment reference from `todowrite` to `todo`
senamakel c6d2201
fix(conversations): handle missing harness state gracefully
senamakel 8d62a8e
refactor(conversations): remove unused toolName helper
senamakel bf7ed69
feat(utils): add display names for harness state tools
senamakel 5193658
fix(conversations): handle empty todo checklist gracefully
senamakel 8e07a5c
fix(conversations): remove duplicate goal banner in conversation view
senamakel 0b775d4
feat(conversations): show agent todo list and thread goal above composer
senamakel 215a129
feat(conversations): import selectThreadGoal and selectTodoList selec…
senamakel 73187a4
feat(i18n): add translations for todos and goal features
senamakel d2127cc
fix(conversations): correct harness state test to verify initial values
senamakel a2a9e0e
fix(todo-checklist): correct test for completed state rendering
senamakel 6b9aeea
fix(test): update GoalBanner test to match new behavior
senamakel 634fb63
test(conversations): provide English i18n templates in test mocks
senamakel 873b53c
fix(i18n): correct token count translations in Spanish and Portuguese
senamakel f6f9d0c
test(agent-access-panel): update switch name matcher in fail-closed test
senamakel f447422
test(agent-harness): add end-to-end tests for todo list and thread go…
senamakel 09653c0
fix(test): replace assertion with diagnostic dump in e2e test
senamakel 491846c
chore: files changed tests/agent_harness_e2e.rs
senamakel 9b716d4
fix(test): use raw string literal for JSON assertion
senamakel 449cfda
fix(conversations): include use_skill in goal tool detection
senamakel 5acc18c
test(agent_harness_e2e): key tool lookups on call id instead of tool …
senamakel f105976
test(agent-harness-e2e): replace brittle token-accounting assertion i…
senamakel af47c17
feat(e2e): add e2e spec for chat, todos, and goals interaction
senamakel dd65044
test(e2e): replace raw DOM click with helper in chat-todos-goals spec
senamakel 15c2cd9
docs(TEST-COVERAGE-MATRIX): add coverage rows for session todo list a…
senamakel 03edbf3
chore: reformat long lines in test and store files
senamakel a43b7c5
test(rpc_log): replace float literal that triggered clippy lint
senamakel 9d7188d
chore(deps): bump vendored tinyagents to the flat todo list
senamakel 6579554
chore: clean up formatting and import grouping in conversation compon…
senamakel 516753b
fix(todo): reflow doc comment to avoid mid-sentence line break
senamakel 7e55d42
docs: reflow doc comment in todo.rs
senamakel c4a3ec6
refactor(harnessState): accept turns as nested arrays instead of a fl…
senamakel 6d13f91
fix(conversations): handle missing thread state on initial render
senamakel e40ecc6
fix(store): export toolTimelineFromPersisted for external use
senamakel 57b25df
refactor(conversations): replace selector calls with a single hook
senamakel 264d03d
test(harnessState): wrap timeline entries in a turn helper
senamakel 4bf5396
fix(conversations): correct thread harness state test for empty initi…
senamakel d13bbfd
test: simplify inline array expectation in useThreadHarnessState test
senamakel 41175a4
fix(imports): consolidate import from chatRuntimeSlice
senamakel 950cef8
test(e2e): clarify comment on thread switch persistence
senamakel 513db1d
feat(chat): rebuild todos and goal from the thread's settled turns
senamakel 82a9090
feat(gitbooks): add documentation for goals and todos in the chat pane
senamakel dafeafd
fix(conversations): handle empty todo checklist gracefully
senamakel ee601f4
fix(conversations): replace text-content-primary with text-content in…
senamakel a283493
fix(GoalBanner): collapse span element to single line
senamakel 2ab68de
chore(deps): update vendor/tinyagents subproject commit
senamakel 898c69b
chore(deps): update tinyagents subproject commit
senamakel 606db34
chore(deps): repin tinyagents to main with the flat todo list
senamakel 19dbbf6
Merge upstream/main into todo-goals-e2e
senamakel 8a59fa5
test(todo): reformat assertion for readability
senamakel 4a72180
chore(deps): update tinyagents subproject commit
senamakel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Reset disclosure state when the selected thread changes.
React reuses these component instances when both threads contain harness state. An expanded goal or collapsed checklist from the previous thread then remains in that state after the thread switch.
Key both components by
selectedThreadId.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents