refactor(flows): move portable authoring assets upstream - #6341
Merged
Merged
Conversation
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Contributor
|
Warning Review paused — included plan limit reachedKeep your review moving with free on-demand reviews.
On-demand reviews are free for the next 2 days. Promotion and pricing detailsOn-demand reviews are free for the next 2 days. After that, they cost $0.25 per reviewed file. Review limit detailsOr wait 5 minutes for your next included review. Limit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (15)
Comment |
Co-authored-by: Medulla <medulla@tinyhumans.ai>
# Conflicts: # crates/openhuman-core/src/agent/registry/agents/orchestrator/prompt_tests.rs # vendor/tinyflows
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Consolidate the collection of file paths into a single expression by removing intermediate variable assignments, making the test code more concise without changing its behavior. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
senamakel
marked this pull request as ready for review
September 18, 2026 20:09
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 1 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Reviewing pending checks Review snapshot
Completeness: Complete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. Findings
Pending checks: Rust E2E (mock backend), Build Playwright E2E Artifact, E2E (Playwright / web lane), Desktop E2E (full suite, 3 OS) Before merge
How this fits togetherflowchart LR
n0["format_connected_mcp_block<br/>changed"]:::changed
n1["...lls_back_to_tool_count_and_qualified_name<br/>changed"]:::changed
n2["format"]:::impacted
n3["build"]:::impacted
n4["render_installed_skills"]:::impacted
n5["execute"]:::impacted
n1 -->|calls| n0
n1 -->|tests| n0
n1 -->|calls| n2
n1 -->|tests| n2
n3 -->|calls| n4
n5 -->|calls| n2
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0160 · 375,533 in / 27,423 out · 6,213 cached (2%) · ladder/vectors, gpt-5.6-luna, deepseek-v4-flash · 1,122 embedded
critique: $0.0084 · 165,211 in / 9,063 out · 3,141 cached (2%) · gpt-5.6-luna, deepseek-v4-flash
security: $0.0047 · 92,349 in / 1,659 out · 0 cached (0%) · gpt-5.6-luna
tests: $0.0008 · 33,489 in / 4,980 out · 1,024 cached (3%) · deepseek-v4-flash
description: $0.0007 · 24,908 in / 2,775 out · 1,024 cached (4%) · deepseek-v4-flash
e2e: $0.0009 · 37,528 in / 5,311 out · 1,024 cached (3%) · deepseek-v4-flash
| .as_str() | ||
| .map(str::to_string) | ||
| }) | ||
| tinyflows::diagnostics::node_error_message(output, node_id) |
There was a problem hiding this comment.
Continue past error entries without a readable message
node_error_message selects the first item containing an error field, then applies error_message to that value. If the first error is an empty object, error_message returns its JSON representation (for example, {}), so a later item containing {"message":"useful detail"} is never examined. The previous implementation skipped entries without a string error.message and would return that later readable message. Preserve the old per-item search semantics, or update the shared helper to continue searching when an error value is not a useful message.
[RULE] error-message-selection ·
tinysweeper
Bot
added
the
priority: p2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flow-authoringresources fromtinyflows-copilotConnectedServerOverviewcontractDependency
Depends on tinyhumansai/tinyflows#91. Mark ready after that PR merges and the submodule pointer is available from
main.Testing
cargo test -p tinyflows-copilot