SYM-208: add PR checklist local preflight#1270
Draft
jwalin-shah wants to merge 2 commits intotinyhumansai:mainfrom
Draft
SYM-208: add PR checklist local preflight#1270jwalin-shah wants to merge 2 commits intotinyhumansai:mainfrom
jwalin-shah wants to merge 2 commits intotinyhumansai:mainfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR_BODY, and stdin pipelines.N/Alines.pnpm pr:checklistalias for the existing script.Problem
Codex-authored PRs can fail the
PR Submission Checklistworkflow after handoff because unchecked template items are only discovered once CI runs. The existing parser also treated uncheckedN/Achecklist items as satisfied.Solution
scripts/check-pr-checklist.mjsnow reads a PR body from a file path, stdin (-), orPR_BODY.scripts/lib/checklist-parser.mjsnow requires every checklist item to be checked.docs/agent-workflows/codex-pr-checklist.mdnow includes local preflight commands for generated body files andgh pr viewpipelines.Submission Checklist
docs/TESTING-STRATEGY.md(N/A: script behavior validated with direct good and bad CLI fixtures)diff-cover) meet the gate enforced by.github/workflows/coverage.yml. Runpnpm test:coverageandpnpm test:rustlocally; PRs below 80% on changed lines will not merge. (N/A: docs/root script change outside app and Rust coverage harnesses)docs/TEST-COVERAGE-MATRIX.mdreflect this change (N/A: agent workflow/script tooling only)## Related(N/A: no coverage matrix feature IDs affected)docs/TESTING-STRATEGY.mddocs/RELEASE-MANUAL-SMOKE.md) (N/A: not a release-cut surface)Closes #NNNin the## Relatedsection (N/A: Linear issue only)Impact
No runtime app impact. This only affects repository tooling and agent workflow documentation.
Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
codex/SYM-208-pr-checklist-preflightff1d78c5fe801f29cccfc6ea3e1139f595b80494Validation Run
pnpm --filter openhuman-app format:check(N/A: no app workspace files changed)pnpm typecheck(N/A: no TypeScript app files changed)pnpm pr:checklist "$ok_file";pnpm pr:checklist "$bad_file"expected failure;PR_BODY="$(cat "$ok_file")" pnpm pr:checklist;printf ... | pnpm pr:checklist -Validation Blocked
command:N/Aerror:N/Aimpact:N/ABehavior Changes
N/A;N/Aitems must be checked with a reason.Parity Contract
PR_BODYworkflow remains supported.Duplicate / Superseded PR Handling