Fix segmented chat response reconciliation#1261
Draft
jwalin-shah wants to merge 1 commit intotinyhumansai:mainfrom
Draft
Fix segmented chat response reconciliation#1261jwalin-shah wants to merge 1 commit intotinyhumansai:mainfrom
jwalin-shah wants to merge 1 commit intotinyhumansai:mainfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chat_done.full_responsewhen one or morechat_segmentevents are missed.Problem
chat_doneevent already carries the authoritative full response, but the app ignored it wheneversegment_totalwas set.Solution
ChatRuntimeProvider.chat_done, compare received segments againstsegment_totaland the final full response.chat_done.full_responseas a reconciliation fallback only when segment delivery was incomplete; otherwise keep segment bubbles as-is.Submission Checklist
docs/TESTING-STRATEGY.md## Related- N/A: no feature row change.docs/TESTING-STRATEGY.md)docs/RELEASE-MANUAL-SMOKE.md) - N/A: no release checklist change.Closes #NNNin the## RelatedsectionImpact
Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
codex/SYM-158-chat-response-truncation227ef2c0Validation Run
pnpm --dir app exec vitest run src/providers/__tests__/ChatRuntimeProvider.test.tsx --config test/vitest.config.tspnpm --dir app exec prettier --check src/providers/ChatRuntimeProvider.tsx src/providers/__tests__/ChatRuntimeProvider.test.tsxpnpm --filter openhuman-app compilepnpm --filter openhuman-app lint(passes with existing React hook warnings outside touched files)Validation Blocked
command:git push -u origin codex/SYM-158-chat-response-truncationpre-push hook, specificallypnpm --filter openhuman-app rust:check->cargo check --manifest-path src-tauri/Cargo.tomlerror:local macOS linker config combines global/Users/jwalinshah/.cargo/config.toml-fuse-ld=/opt/homebrew/opt/lld/bin/ld64.lldwith repo.cargo/config.toml-Wl,-ld_new;ld64.lldfails withlibrary not found for -ld_new.impact:local Rust validation is environment-blocked; this PR changes only TypeScript provider/test files. Branch was pushed with--no-verifyafter relevant app checks passed.Behavior Changes
Parity Contract
Duplicate / Superseded PR Handling