what do you think about golangci-lint?

[gen2thomas]

At least all drivers without the machine package import could be checked. I have tested this with the default settings of linter for the ds18b20 folder as an fast example and got 3 important issues regarding a missing check of error return value:

ds18b20.go:47:15: Error return value of `d.owd.Select` is not checked (errcheck)
		d.owd.Select(romid)
		            ^
ds18b20.go:57:14: Error return value of `d.owd.Select` is not checked (errcheck)
	d.owd.Select(romid)
	            ^
ds18b20.go:67:14: Error return value of `d.owd.Select` is not checked (errcheck)
	d.owd.Select(romid)
	            ^
ds18b20.go:32:23: ST1005: error strings should not end with punctuation or newlines (staticcheck)
	errReadTemperature = errors.New("Error: DS18B20. Read temperature error: CRC mismatch.")
	                     ^
4 issues:
* errcheck: 3
* staticcheck: 1

Currently gofmt is used in the Makefile.

[aykevl]

I think it's a great idea. Though, it may be best to limit checking to new and modified files if possible.

Would you like to make a PR?

[gen2thomas]

Hi @aykevl , I have prepared 3 different approaches to run the linter locally and in CI. Please can you have a look and make a decision? Its best to start with reading on #802 . I tried to add some background information to each PR, but maybe there are open questions...

Once we have made a decision I can optimize more regarding namings etc.