Skip to content

Solve implicitly nullable parameters #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timoschinkel merged 2 commits into from
Mar 10, 2026
Merged

Solve implicitly nullable parameters #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fe4d8e
Solve implicitly nullable parameters
timoschinkel Mar 10, 2026
6ab87f9
Drop support for PHP 8.1
timoschinkel Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: ['8.1', '8.2', '8.3', '8.4']
php-versions: ['8.2', '8.3', '8.4']
symfony-versions: ['^6.0', '^7.0']
name: PHP ${{ matrix.php-versions }} with Symfony ${{ matrix.symfony-versions }}

Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.6.1] - 2026-03-10
### Changed
- Solve implicitly nullable parameters to better support PHP 8.4 ([#27](https://github.com/timoschinkel/codeowners-cli/pull/27))

### Removed
- Support for PHP 8.1 ([#27](https://github.com/timoschinkel/codeowners-cli/pull/27))

## [1.6.0] - 2025-05-28
### Added
- `-o`/`--owner-only` option for `codeowners owner` to print only the owner ([#26](https://github.com/timoschinkel/codeowners-cli/pull/26))
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "project",
"license": "Apache-2.0",
"require": {
"php": "^8.1",
"php": "^8.2",
"symfony/console": "^6.0|^7.0",
"timoschinkel/codeowners": "^2.0",
"symfony/finder": "^6.0|^7.0"
Expand Down
2 changes: 1 addition & 1 deletion src/FileLocator/FileLocatorFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

final class FileLocatorFactory implements FileLocatorFactoryInterface
{
public function getFileLocator(string $workingDirectory, string $specifiedFile = null): FileLocatorInterface
public function getFileLocator(string $workingDirectory, ?string $specifiedFile = null): FileLocatorInterface
{
return $specifiedFile !== null
? new SpecifiedFileLocator($specifiedFile)
Expand Down
2 changes: 1 addition & 1 deletion src/FileLocator/FileLocatorFactoryInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@

interface FileLocatorFactoryInterface
{
public function getFileLocator(string $workingDirectory, string $specifiedFile = null): FileLocatorInterface;
public function getFileLocator(string $workingDirectory, ?string $specifiedFile = null): FileLocatorInterface;
}