- Added entities "Security" and "Currency"#4
Open
jross765 wants to merge 1 commit intotimerickson:masterfrom
Open
- Added entities "Security" and "Currency"#4jross765 wants to merge 1 commit intotimerickson:masterfrom
jross765 wants to merge 1 commit intotimerickson:masterfrom
Conversation
- Adapted setup.py and .gitignore Partially reverted changes in setup.py (for pull request, got ahead of myself) - fileinfo, payee: Adaptations to new file format 1.9 (KMM version 5.2.x) - tag: Small improvements - kmy: Improved readability Updated README (and changed extension according to newer conventions) Updated tests: - Converted Test.kmy to new file format - Added test cases for new entities (currencies, securities) - Adapted test cases for new file format (fileinfo) - Removed redundant files - Some small stuff Tests: Small corr.s in new files Reverted README to RST format (so used to writing Markdown...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Tim,
I understand you accept merge requests. I like your work!
I had some spare time and worked on your package. Details cf. below.
P.S.: I would suggest that you add tags to your repo -- it took me a while to find it.
James
Partially reverted changes in setup.py (for pull request, got ahead of myself)
Updated README (and changed extension according to newer conventions)
Updated tests:
Tests: Small corr.s in new files
Reverted README to RST format (so used to writing Markdown...)