word boundary matching and translations - #15
Open
mbaumgart wants to merge 4 commits into
Open
Conversation
added 4 commits
April 29, 2016 23:15
to prevent false chain translations like 'drehen' -> 'rotate' -> 'redate', the loop to translate/replace values now breaks when the first replacement happened
This solution now does accept brackets, multi values and prevents to translate only parts of words
Owner
|
Sorry for the delay, but thanks for this PR :) Can you please rebase to resolve the conflicts? I'll merge it then and would be happy to release a new version then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used word boundary matching for css values to respect the new test cases, added further translations and generated docs.