fix(check): resolve callee dispatch and optional weights - #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
analyze --dimrejected a call to a dispatch prototype even when the caller's dimension bindings selected exactly one variant.checkrequired--weightseven when a run reached no weights, while a declaration-based gate could not identify weights reached through child modules.What
variant_forduring dimension specialization, recursively rebuild the chosen body, and preserve specialization provenance.--weightsan empty resource so unused weights need no source and reached weights fail at their first read with the declaring module and weight name.Contract
--weightsis optional. Without it, a reached weight is rejected at first use and names its declaring Module and weight.Risk
gen_model.pydocuments the removed specialization limit but intentionally still emits the directattend_by_contextcall; switching it back to the prototype is a separate model change.