Skip to content

Persist explicit memory feedback #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
importcpp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Persist explicit memory feedback #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/agent_memory/core/store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ def feedback(self, name: str, delta: float) -> MemoryRecord:
current.weight = min(
self.config.weight.ceiling, max(self.config.weight.floor, current.weight + delta)
)
return current
return self.write(current)

def read(self, name: str, level: str = LEVEL_FULL) -> ReadResult:
if level not in LEVELS:
Expand Down
10 changes: 7 additions & 3 deletions tests/unit/test_recall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from agent_memory.core.access_log import AccessLog
from agent_memory.core.database import Database
from agent_memory.core.recall import Recall
from agent_memory.core.store import LEVEL_ABSTRACT, LEVEL_OUTLINE
from agent_memory.core.store import LEVEL_ABSTRACT, LEVEL_OUTLINE, Store


def _names(hits):
Expand Down Expand Up @@ -87,9 +87,13 @@ def test_weight_reorders_two_otherwise_comparable_hits(seeded):
name="drain-notes-a",
)
baseline = _names(Recall(seeded).recall("deploy notes drain window"))
before = seeded.find("drain-notes-b").weight
seeded.feedback("drain-notes-b", seeded.config.weight.boost_step)
boosted = _names(Recall(seeded).recall("deploy notes drain window"))
assert boosted.index("drain-notes-b") <= baseline.index("drain-notes-b")
reopened = Store(seeded.root, config=seeded.config, clock=seeded.clock)
boosted = _names(Recall(reopened).recall("deploy notes drain window"))
assert baseline.index("drain-notes-a") < baseline.index("drain-notes-b")
assert boosted.index("drain-notes-b") < boosted.index("drain-notes-a")
assert reopened.find("drain-notes-b").weight == before + seeded.config.weight.boost_step


def test_recall_writes_the_access_log_and_leaves_truth_bytes_untouched(seeded):
Expand Down