Repository navigation
chore: rosdep で解決できなくなった python-pulsectl-pip 依存を削除 - #219
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
src/signageとsrc/external_signageのpackage.xmlからpython-pulsectl-pipを削除します。背景
python-pulsectl-pipは rosdep で解決できなくなり、rosdep installが失敗するようになりました。変更内容
src/signage/package.xml:<depend>python-pulsectl-pip</depend>を削除src/external_signage/package.xml:<depend>python-pulsectl-pip</depend>を削除補足
src/signage/src/signage/announce_controller.pyは引き続きpulsectlを使用しています。実行環境では、別途 pip でpulsectlをインストールしておく必要があります。external_signageにはpulsectlを使用しているコードがないため、不要になった依存の整理も兼ねています。🤖 Generated with Claude Code