Repository navigation
fix: package.xmlからpython-pulsectl-pip依存を削除 (beta/v4.4.0.1) - #209
Merged
Merged
Conversation
python-pulsectl-pipのrosdep keyが削除されたため、rosdepでの依存解決が 失敗するようになった。pulsectlのインストールはautoware_ecu_system_setupの x2_signage_env_setupのpip installに移管するため、package.xmlの依存宣言を削除する。 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
python-pulsectl-pipの rosdep key が削除されたため、rosdep installでの依存解決が失敗するようになりました。pulsectlのインストールはautoware_ecu_system_setupのx2_signage_env_setupの pip install に移管するため、package.xml からの依存宣言を削除します。変更内容
src/signage/package.xmlから<depend>python-pulsectl-pip</depend>を削除src/external_signage/package.xmlから<depend>python-pulsectl-pip</depend>を削除注意点
announce_controller.pyのfrom pulsectl import Pulseはそのままです（実行時は pip でインストールされた pulsectl を使用）。x2_signage_env_setupを通していない環境（ローカルのrosdep install・CI 等）ではpulsectlが入らずImportErrorになります。pulsectl を使う全経路で pip install がカバーされているか確認が必要です。autoware_ecu_system_setupへの pulsectl 追加) は別リポジトリで別途対応します。🤖 Generated with Claude Code