chore: sync branch by operationtoolapp[bot] · Pull Request #204 · tier4/AutowareSignage

operationtoolapp · 2026-07-03T00:31:37Z

Features

外部指示による表示変更 (feat: 外部指示による表示変更 #200)

Bug Fixes

Resolve spellcheck failures in CI
Exclude spell_check_pr.yml from cspell targets
Add pytest config keywords to cspell dictionary
Migrate cspell dictionary from curl to npm install
Exclude package.xml from cspell targets
Bump pre-commit/action from v2.0.3 to v3.0.1
Update black to 26.1.0 and fix pre-commit formatting issues
Remove unused signage/packet_tools.py and its test

Code Refactoring

Externalize FMS host and port via environment variables (refactor: externalize FMS host and port via environment variables #197)

Tests

Add unit tests for signage/packet_tools.py
Add unit tests for signage/signage_utils.py
Add unit tests for external_signage/packet_tools.py

Continuous Integrations

Add GitHub Actions workflow for tests and SonarCloud analysis

Chores

Add pytest configuration and test directory structure
Add SonarCloud configuration
Remove level4_mode_manager_msgs (use l4_toolkit) (chore: remove level4_mode_manager_msgs (use l4_toolkit) #190)
Add .graphrag to .gitignore

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add 25 tests covering calc_sum, verify_sum, gen_data_packet, gen_data_packets, gen_name_time_packet, lists_match, and Parser. Also fix test infrastructure: remove tests/signage/__init__.py that shadowed the real signage package, and add sys.path setup to conftest.py for pytest < 7.0 compatibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Remove __init__.py that shadows the real external_signage package, rename test to test_ext_packet_tools.py to avoid module name collision with signage/test_packet_tools.py on pytest < 7, and disable launch_testing plugins in pytest.ini addopts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Replace abbreviated test data "sched-1/2" with "schedule-1/2" - Exclude pytest.ini from cspell check (contains pytest-specific keywords) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

The workflow file itself contains tool names (jq, cspell) that are not in the shared dictionary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ignorePaths does not work with cspell-action's incremental file detection, so add the words directly instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

cspell/.cspell.json in tier4/autoware-spell-check-dict has not been synced since 2022-02 and is missing 500+ words compared to the root .cspell.json. Switch to npm install --ignore-scripts to get the up-to-date dictionary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

package.xml is ROS 2 package metadata containing personal names, email addresses, and package identifiers that are not English words. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Black 22.3.0 crashes on Python 3.14 due to removed asyncio.get_event_loop(). Also fix end-of-file and trailing whitespace issues caught by pre-commit hooks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

signage/packet_tools.py is not imported anywhere in the signage package. The external_signage copy remains as it is actively used. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Chore/add sonarcloud analysis

Remove hardcoded FMS domain and gateway port from the source so they are no longer baked into the public repository. They are now read from the FMS_URL, AUTOWARE_IP, and AUTOWARE_PORT environment variables, which the x2_signage_env_setup Ansible role provisions into autoware.env on production vehicles. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: do not launch external_signage from signage.launch.xml (#194) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Revert "chore: remove level4_mode_manager_msgs (use l4_toolkit) (#190)" This reverts commit cffbf6f. * feat: add use_external_signage flag and relax airport_mode QoS (#195) * delete external control * feat: add use_external_signage flag and relax airport_mode QoS Introduce use_external_signage launch argument (default false) so the external_signage node and its ROS service wiring are only activated when explicitly enabled, preventing signage from blocking on a non-existent /signage/trigger_external service. Also relax /signage/airport_mode subscription durability to VOLATILE so external_signage can receive from both TRANSIENT_LOCAL and VOLATILE publishers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat: add CommandViewManager integration for in_vehicle_signage Subscribe CVM command topic to override view_mode (between disconnected and other autoware-driven modes). Publish state mapped from current view_mode to CVM display_mode_id, filtered by manifest support (unsupported modes fall back to idle_display). Override is cleared by receiving idle_display from a client. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat: separate CVM-driven displays into dedicated CvmDisplayView Route all CVM commands to a new cvm_display view_mode and branch inside CvmDisplayView based on cvm_display_mode_id, keeping the autoware-internal emergency_stopped view independent. First sub-page is CvmEmergencyStop ("緊急停止中" / "Emergency Stop"). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(cvm): separate remote/MRM emergency displays - Rename external command display_mode_id to remote_emergency_display so it is distinct from the MRM-originated emergency stop - Restyle CvmEmergencyStop with an orange background and "オペレーター停止指示 / Stopped by Operator" text plus a warning icon - Report emergency_stopped (vehicle MRM) state to CVM as mrm_emergency_display instead of the shared emergency_display Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

GraphRAG knowledge vault is managed in a separate private repository (AutowareSignage-vault) to keep project knowledge out of the public repo. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

chore: add .graphrag to .gitignore

suzuki0keiichi and others added 25 commits February 20, 2026 15:05

chore: add pytest configuration and test directory structure

9344b88

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

test: add unit tests for signage/signage_utils.py

a1165a9

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

chore: add SonarCloud configuration

b936959

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ci: add GitHub Actions workflow for tests and SonarCloud analysis

4bf94e9

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: resolve spellcheck failures in CI

3c06731

- Replace abbreviated test data "sched-1/2" with "schedule-1/2" - Exclude pytest.ini from cspell check (contains pytest-specific keywords) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: exclude spell_check_pr.yml from cspell targets

2f8c99a

The workflow file itself contains tool names (jq, cspell) that are not in the shared dictionary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: add pytest config keywords to cspell dictionary

9559485

ignorePaths does not work with cspell-action's incremental file detection, so add the words directly instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: exclude package.xml from cspell targets

881a259

package.xml is ROS 2 package metadata containing personal names, email addresses, and package identifiers that are not English words. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: bump pre-commit/action from v2.0.3 to v3.0.1

b3feb33

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: update black to 26.1.0 and fix pre-commit formatting issues

8aa2de0

Black 22.3.0 crashes on Python 3.14 due to removed asyncio.get_event_loop(). Also fix end-of-file and trailing whitespace issues caught by pre-commit hooks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: remove unused signage/packet_tools.py and its test

5f0d83f

signage/packet_tools.py is not imported anywhere in the signage package. The external_signage copy remains as it is actively used. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Merge pull request #186 from tier4/chore/add-sonarcloud-analysis

446d2d9

Chore/add sonarcloud analysis

chore: remove level4_mode_manager_msgs (use l4_toolkit) (#190)

cffbf6f

fix (#191)

70e568e

fix (#192)

55c2802

fix (#193)

7eab6d5

delete msg (#199)

cfcc46c

chore: add .graphrag to .gitignore

d023e93

GraphRAG knowledge vault is managed in a separate private repository (AutowareSignage-vault) to keep project knowledge out of the public repo. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Merge pull request #203 from tier4/chore/exclude-graphrag-from-git

971ca6e

chore: add .graphrag to .gitignore

yabuta closed this Jul 14, 2026

Navigation Menu

Repository navigation

chore: sync branch - #204

chore: sync branch#204
operationtoolapp[bot] wants to merge 25 commits into
isuzu_erga_evfrom
sync-branch

operationtoolapp Bot commented Jul 3, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

operationtoolapp Bot commented Jul 3, 2026

Features

Bug Fixes

Code Refactoring

Tests

Continuous Integrations

Chores

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants