align column family LSM level defaults to the library and pin them#138
Merged
Conversation
tidesdb_default_min_levels and tidesdb_default_dividing_level_offset shipped at 5 and 2 while the underlying TidesDB library's tidesdb_default_column_family_config picks 1 and 1, so a table created in the plugin had a deeper level structure than the same table created through bare libtidesdb without any reason behind the divergence.The two THDVAR defaults now match TDB_DEFAULT_MIN_LEVELS and TDB_DEFAULT_DIVIDING_LEVEL_OFFSET so a freshly created table behaves the same in both layers.tidesdb_analyze and tidesdb_index_stats are re-recorded since ANALYZE TABLE now reports the smaller initial level count. The README grows a DEFAULTS ALIGNMENT WITH THE LIBRARY section that spells out the three deliberate column family deviations left in place (SYNC_MODE=FULL for SQL durability, ISOLATION_LEVEL=REPEATABLE_READ to match MariaDB's session default, WRITE_BUFFER_SIZE=128MB for the typical OLTP server profile) and confirms every other CF default tracks the library exactly.The Available tests roster is brought into 1:1 sync with the suite, bumping the count from 51 to 65, dropping the stale tidesdb_alter_crash entry, and adding the rows that had drifted out of the README (tidesdb_alter_large_table, tidesdb_bulk_commit_durability, tidesdb_defaults_alignment, tidesdb_encryption_rotation, tidesdb_fts_stopword_table, tidesdb_isolation_table_option, tidesdb_max_concurrent_flushes, tidesdb_mvcc_concurrent_update, tidesdb_update_unique).tidesdb_defaults_alignment is a new MTR test that SHOWs every per-table-option default so any future drift, accidental or intentional, has to update the recorded result and be acknowledged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tidesdb_default_min_levels and tidesdb_default_dividing_level_offset shipped at 5 and 2 while the underlying TidesDB library's tidesdb_default_column_family_config picks 1 and 1, so a table created in the plugin had a deeper level structure than the same table created through bare libtidesdb without any reason behind the divergence.The two THDVAR defaults now match TDB_DEFAULT_MIN_LEVELS and TDB_DEFAULT_DIVIDING_LEVEL_OFFSET so a freshly created table behaves the same in both layers.tidesdb_analyze and tidesdb_index_stats are re-recorded since ANALYZE TABLE now reports the smaller initial level count.
The README grows a DEFAULTS ALIGNMENT WITH THE LIBRARY section that
spells out the three deliberate column family deviations left in place (SYNC_MODE=FULL for SQL durability, ISOLATION_LEVEL=REPEATABLE_READ to match MariaDB's session default, WRITE_BUFFER_SIZE=128MB for the typical OLTP server profile) and confirms every other CF default tracks the library exactly.The Available tests roster is brought into 1:1 sync with the suite, bumping the count from 51 to 65, dropping the stale tidesdb_alter_crash entry, and adding the rows that had drifted out of the README (tidesdb_alter_large_table, tidesdb_bulk_commit_durability, tidesdb_defaults_alignment, tidesdb_encryption_rotation, tidesdb_fts_stopword_table, tidesdb_isolation_table_option, tidesdb_max_concurrent_flushes, tidesdb_mvcc_concurrent_update, tidesdb_update_unique).tidesdb_defaults_alignment is a new MTR test that SHOWs every per-table-option default so any future drift, accidental or intentional, has to update the recorded result and be acknowledged.