Open
Conversation
Contributor
darinkrauss
commented
Mar 18, 2026
- Refactor oura package layout
- Move data structures to top-level oura package
- Remove unnecessary GroupID and SerialID from revoke work
- Add cumulative oura processor dependencies
- Refactor oura package layout - Move data structures to top-level oura package - Remove unnecessary GroupID and SerialID from revoke work - Add cumulative oura processor dependencies
There was a problem hiding this comment.
Pull request overview
Refactors the Oura integration package layout by moving shared client APIs and data structures into the top-level oura package, and updating work processors/providers to use the new locations.
Changes:
- Move Oura client interface and subscription/personal-info structs to
oura/oura.goand update client implementation signatures accordingly. - Reorganize work processor packages (
oura/data/work/...,oura/webhook/work/...,oura/users/work/...) and update imports/processor dependencies. - Remove the old
oura/work/usershelpers and adjust revoke work creation logic.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| oura/work/work.go | Removes old oura/work client interface; adds provider-session group ID helper. |
| oura/work/users/users.go | Deletes old users work ID helpers. |
| oura/work/processors/processors.go | Moves processor-factory wiring into processors package; adds dependency validation and updates imports to new layout. |
| oura/webhook/work/subscribe/processor.go | Switches dependency type from old work client interface to oura.Client. |
| oura/webhook/webhook.go | Removes subscription structs from webhook package (now in oura). |
| oura/users/work/revoke/processor.go | Updates to oura.Client and removes GroupID/SerialID from revoke work creation. |
| oura/provider/provider.go | Updates references to new work packages and group ID helpers. |
| oura/oura.go | Adds Client interface + subscription/personal-info structs at top-level oura. |
| oura/data/work/work.go | Renames package to work (import path oura/data/work). |
| oura/data/work/setup/processor.go | Updates to oura.Client and new work package paths. |
| oura/data/work/historic/processor.go | Updates to oura.Client and new work package paths. |
| oura/data/work/event/processor.go | Updates to oura.Client and new work package paths. |
| oura/data/data.go | Deletes old PersonalInfo definition (now in oura). |
| oura/client/client.go | Updates method signatures/types to use new top-level oura structs and times.TimeRange. |
Comments suppressed due to low confidence (1)
oura/users/work/revoke/processor.go:114
work.Createvalidation requires non-emptygroupIdandserialId(see work/work.go Create.Validate). This work creator no longer sets either field, so creating revoke work will fail validation in the work store/client. Please either restoreGroupID/SerialIDfor revoke work (e.g., derived from providerSession.ID) or relax the validation rules if they are truly optional for this work type (but that change would need to be applied consistently across the work system).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Updates based upon feedback included in later PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.